Update cli to fail create/update sequences with limits - #348
Open
mdeuser wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
rabbah
reviewed
Jul 6, 2018
Comment thread
commands/action.go
| } | ||
|
|
||
| if (Flags.action.sequence && (cmd.LocalFlags().Changed(MEMORY_FLAG) || cmd.LocalFlags().Changed(LOG_SIZE_FLAG) || cmd.LocalFlags().Changed(TIMEOUT_FLAG))) { | ||
| errStr := wski18n.T("A sequence cannot have a memory limit, a log size limit or a timeout limit.") |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Can we transition to using message identifiers instead as in https://github.com/apache/incubator-openwhisk-cli/blob/master/commands/messages.go#L26.
Sorry, something went wrong.
| expectedExitCode = MISUSE_EXIT) | ||
| } | ||
|
|
||
| it should "reject create or update of an action sequence that sets a memory limit" in withAssetCleaner(wskprops) { (wp, assetHelper) => |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
all of these might be better suited as go unit tests - i think it makes sense to start adding new tests that are strictly testing the CLI in go.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #347