FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: satisfy Rust 1.98 chunks lint by shyjsarah · Pull Request #750 · apache/paimon-rust · GitHub

fix: satisfy Rust 1.98 chunks lint - #750

Merged
jerry-024 merged 1 commit into
apache:mainfrom
shyjsarah:fix/clippy-as-chunks
Aug 27, 2026
Merged

fix: satisfy Rust 1.98 chunks lint#750
jerry-024 merged 1 commit into
apache:mainfrom
shyjsarah:fix/clippy-as-chunks

Conversation

Copy link
Copy Markdown
Contributor

Summary

Restore the workspace Clippy check after Rust 1.98 enabled chunks_exact_to_as_chunks by default. This failure is already present on main and also blocks unrelated PRs such as #747 and #749.

Changes

  • Replace constant-size chunks_exact calls with as_chunks in Murmur hashing.
  • Update fixed-width vector score test iteration.
  • Update Hybrid Search named-struct and options pair iteration.
  • Preserve the existing even-length/alignment validation and runtime behavior.

Testing

  • cargo +1.98.0 clippy --locked --all-targets --workspace --features fulltext,vortex -- -D warnings
  • cargo +1.98.0 test -p paimon spec::murmur_hash --lib
  • cargo +1.98.0 test -p paimon test_raw_vector_score_matrix_matches_scalar_metrics --lib
  • cargo +1.98.0 test -p paimon-datafusion --test read_tables hybrid_search_tests
  • Verified as_chunks compiles with the workspace MSRV, Rust 1.91.0.
  • cargo fmt --all -- --check
  • git diff --check

Notes

No public API or behavior changes.

QuakeWang left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

+1

jerry-024 merged commit 96a3f7b into apache:main Aug 27, 2026
13 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL