| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
cc @LDVSOFT who reports this issue |
Sorry, something went wrong.
|
I'm not familiar with this. Could you help review this? @gszadovszky |
Sorry, something went wrong.
|
@pan3793, could you elaborate a bit more on what is happening here? The jackson based services are not available currently because of the shading, right? Which means, that parquet-java does not use them. We do not want to make them available. We are shading jackson, so systems depending on parquet-java would not use it directly. |
Sorry, something went wrong.
@gszadovszky Probably right, because I haven't seen user reports issues related to that. But this can not be proven by UT, because currently, Maven UT always runs against vanilla Jackson libs, class relocation only happens on packaging. Anyway, we should either correctly transform those service files or purge them. Generally, applying ServicesResourceTransformer is preferred to keep the functionality completeness of the shaded libs, for example, we generally keep all classes of the shaded lib instead of keeping only the used classes. |
Sorry, something went wrong.
|
@pan3793, can the shaded services interfere with a potential official Jackson library on the classpath? If not, I'm good with this. If yes, we should rather purge the services that we are not using. |
Sorry, something went wrong.
There was a problem hiding this comment.
Thank you, @pan3793 for the clarification. I'm OK getting this in.
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Rationale for this change
Fix #3253
What changes are included in this PR?
As the title.
Are these changes tested?
Before

After

Are there any user-facing changes?
No.
Closes #3253