GH-3715: Validate dictionary IDs while decoding - #3718
Open
arnabnandy7 wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Signed-off-by: Arnab Nandy <arnab_nandy7@yahoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Dictionary-encoded data pages may contain an ID that exceeds the valid range of the associated dictionary. Currently, this causes an ArrayIndexOutOfBoundsException when the dictionary implementation accesses its backing array, obscuring the actual data corruption.
What changes are included in this PR?
Are these changes tested?
Yes. A unit test constructs a dictionary-encoded page containing an out-of-range ID and verifies that reading it throws a descriptive ParquetDecodingException.
./mvnw -pl parquet-column -Dtest=TestDictionary testAre there any user-facing changes?
Yes. Corrupt dictionary-encoded data now produces a descriptive ParquetDecodingException instead of exposing an internal ArrayIndexOutOfBoundsException. Valid Parquet files are unaffected.
Closes #3715