[fix][test] Add timeout to initial receives in ResendRequestTest.testSharedSingleAckedPartitionedTopic - #25828
Merged
lhotari merged 1 commit intoMay 20, 2026
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…SharedSingleAckedPartitionedTopic
The test creates a partitioned topic with 3 partitions, produces 10
messages via RoundRobinPartition (so ~3-4 per partition), and subscribes
two consumers with a Shared subscription and receiverQueueSize=7. Because
the receive queue is larger than the per-partition message count, the
broker can dispatch every message to whichever consumer connected first,
leaving the other consumer's queue empty.
The test then calls consumer1.receive() followed by consumer2.receive()
with no timeout. If consumer2 got nothing, that second call blocks
forever and the test times out:
org.testng.internal.thread.ThreadTimeoutException: Method ... didn't finish within the time-out 60000
...
at GrowableArrayBlockingQueue.take(GrowableArrayBlockingQueue.java:200)
at MultiTopicsConsumerImpl.internalReceive(MultiTopicsConsumerImpl.java:388)
at ConsumerBase.receive(ConsumerBase.java:282)
at ResendRequestTest.testSharedSingleAckedPartitionedTopic(ResendRequestTest.java:517)
Use timeouts on the initial receives like the loop below does. The
totalMessages assertion at the end of the receive loop still verifies
that both consumers together got all 10 messages, so we don't lose
coverage by allowing a null on the first receive.
Example failure:
https://scans.gradle.com/s/by57j4rphce62/tests/task/:pulsar-broker:test/details/org.apache.pulsar.broker.service.ResendRequestTest/testSharedSingleAckedPartitionedTopic/2/output
void-ptr974
approved these changes
May 20, 2026
lhotari
approved these changes
May 20, 2026
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
May 27, 2026
…SharedSingleAckedPartitionedTopic (apache#25828) (cherry picked from commit 55e6022)
priyanshu-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 9, 2026
…SharedSingleAckedPartitionedTopic (apache#25828) (cherry picked from commit 55e6022) (cherry picked from commit 3ed4a9c)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
ResendRequestTest.testSharedSingleAckedPartitionedTopic creates a partitioned topic with 3 partitions, produces 10 messages via RoundRobinPartition (so ~3-4 per partition), and subscribes two consumers with a Shared subscription and receiverQueueSize=7. Because the receive queue is larger than the per-partition message count, the broker can dispatch every message to whichever consumer connected first, leaving the other consumer's queue empty.
The test then calls the two initial receives without a timeout:
If consumer2 got nothing, that second call blocks forever and the test trips the 60s timeOut:
org.testng.internal.thread.ThreadTimeoutException: Method ... didn't finish within the time-out 60000 ... at GrowableArrayBlockingQueue.take(GrowableArrayBlockingQueue.java:200) at MultiTopicsConsumerImpl.internalReceive(MultiTopicsConsumerImpl.java:388) at ConsumerBase.receive(ConsumerBase.java:282) at ResendRequestTest.testSharedSingleAckedPartitionedTopic(ResendRequestTest.java:517)Example failure: https://scans.gradle.com/s/by57j4rphce62/tests/task/:pulsar-broker:test/details/org.apache.pulsar.broker.service.ResendRequestTest/testSharedSingleAckedPartitionedTopic/2/output
Modifications
Use timeouts on the initial receives, matching the loop below them. The assertEquals(messageCount1 + messageCount2, totalMessages) check at the end of the receive loop still verifies that both consumers together got all 10 messages, so coverage isn't lost by tolerating a null on the very first receive.
Verifying this change
This change is already covered by ResendRequestTest.testSharedSingleAckedPartitionedTopic. Locally I ran 5 times with --rerun-tasks; all passed.
Does this pull request potentially affect one of the following parts: