FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[feat][txn] Add TxnID and TransactionCoordinatorClient support to TransactionV5 by TomaszGaweda · Pull Request #26731 · apache/pulsar · GitHub

/ pulsar Public

[feat][txn] Add TxnID and TransactionCoordinatorClient support to TransactionV5 - #26731

Draft
TomaszGaweda wants to merge 2 commits into
apache:masterfrom
TomaszGaweda:add-txnid-to-TransactionV5
ConversationCommits (2)ChecksFiles changed
Draft

[feat][txn] Add TxnID and TransactionCoordinatorClient support to TransactionV5#26731
TomaszGaweda wants to merge 2 commits into
apache:masterfrom
TomaszGaweda:add-txnid-to-TransactionV5

Conversation

TomaszGaweda commented Sep 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Motivation

Many streaming engines need to operate on Transaction IDs to deal with exactly-once delivery guarantees.

Previously, in #26646 we've exposed TransactionCoordinatorClient to allow usage in such engines.

This PR does basically the same, but for V5 API, making it ready for streaming engines.

Modifications

Since v5 API does not depend on v4 API, I've copied TxnID and TransactionCoordinatorClient + Exceptions to v5. In PulsarClientV5 I'm returning this wrapped TransactionCoordinatorClient.
TransactionCoordinatorClientV5 just delegates tasks to v4 API, just like most other APIs.

Verifying this change

  • Make sure that the change passes the CI checks.

Every test invoking transactions on V5 API will now test this change.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

merlimat requested changes Sep 28, 2026
View reviewed changes

merlimat left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This was intentionally left out from the v5 API to avoid exposing internals.

I think it would be better to have a discussion on what it's needed instead of exposing the transaction client which is not meant to.

TomaszGaweda commented Sep 28, 2026

Copy link
Copy Markdown
Contributor Author

@merlimat I am open to discussion, can share stream engine developer PoV :)

merlimat commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

@TomaszGaweda Definitely want to hear you PoV! Can you start a thread on the dev@pulsar.apache.org or a new GitHub discussion to explain what "help" do you need from the client API?

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

merlimat merlimat requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL