FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add timeout support and log setting for client by duhenglucky · Pull Request #50 · apache/rocketmq-client-python · GitHub

Add timeout support and log setting for client - #50

Merged
ShannonDing merged 3 commits into
apache:masterfrom
duhenglucky:log
Oct 11, 2019
Merged

Add timeout support and log setting for client #50
ShannonDing merged 3 commits into
apache:masterfrom
duhenglucky:log

Conversation

Copy link
Copy Markdown
Contributor

What is the purpose of the change

(1) add log setting support
(2) add send message timeout support

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

ShannonDing merged commit 95a5a38 into apache:master Oct 11, 2019
ShannonDing added the enhancement New feature or request label Oct 31, 2019
ShannonDing added this to the 1.2.4 milestone Oct 31, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL