FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix NoSuchMethodError in mvc-annotation-commons&change deprecated method by CzyerChen · Pull Request #658 · apache/skywalking-java · GitHub

/ skywalking-java Public

Fix NoSuchMethodError in mvc-annotation-commons&change deprecated method - #658

Merged
wu-sheng merged 2 commits into
apache:mainfrom
CzyerChen:bugfix/11652
Dec 15, 2023
ConversationCommits (2)ChecksFiles changed
Merged

Fix NoSuchMethodError in mvc-annotation-commons&change deprecated method#658
wu-sheng merged 2 commits into
apache:mainfrom
CzyerChen:bugfix/11652

Conversation

CzyerChen commented Dec 14, 2023 •
edited by wu-sheng
Loading

Copy link
Copy Markdown
Contributor

Fix NoSuchMethodError in mvc-annotation-commons&change deprecated method

wu-sheng added bug Something isn't working plugin labels Dec 14, 2023
wu-sheng added this to the 9.2.0 milestone Dec 14, 2023

wu-sheng commented Dec 14, 2023

Copy link
Copy Markdown
Member

I want to double-check, this test has covered 3.2.18.RELEASE, so, only 3.2.0 had the bug, but 3.2.8 is OK?

CzyerChen commented Dec 14, 2023

Copy link
Copy Markdown
Contributor Author

I want to double-check, this test has covered 3.2.18.RELEASE, so, only 3.2.0 had the bug, but 3.2.8 is OK?

I can write a scenario with version 3.2.18.RELEASE and test again locally.

wu-sheng commented Dec 14, 2023

Copy link
Copy Markdown
Member

The link I provided, it has tested 3.1.4.RELEASE, 3.2.18.RELEASE, 4.0.9.RELEASE, check this, https://github.com/apache/skywalking-java/blob/main/test/plugin/scenarios/spring-3.1.x-scenario/support-version.list.

What I want to confirm with you is, is this test covers your scenario if we add 3.2.0.xx into that? Or 3.2.18 is still having this bug just not covered by the test.

CzyerChen commented Dec 15, 2023

Copy link
Copy Markdown
Contributor Author

The link I provided, it has tested 3.1.4.RELEASE, 3.2.18.RELEASE, 4.0.9.RELEASE, check this, https://github.com/apache/skywalking-java/blob/main/test/plugin/scenarios/spring-3.1.x-scenario/support-version.list.

What I want to confirm with you is, is this test covers your scenario if we add 3.2.0.xx into that? Or 3.2.18 is still having this bug just not covered by the test.

wu-sheng reviewed Dec 15, 2023
View reviewed changes
Comment thread test/plugin/scenarios/spring-6.x-scenario/support-version.list

6.0.4
6.1.0
6.1.1

wu-sheng Dec 15, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

So, only this is using SpringBoot 3.2.0, which was failing before the fix, am I getting your idea correctly?

CzyerChen Dec 15, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

yes, I tracd my own springboot project in 3.2.0(Spring 6.1.1), and find SpringMVC node missing, but springboot project in 3.1.6(Spring 6.0.14) works.

wu-sheng merged commit fdc1e97 into apache:main Dec 15, 2023
CzyerChen deleted the bugfix/11652 branch May 11, 2024 06:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

wu-sheng wu-sheng approved these changes

Assignees

No one assigned

Labels

bug Something isn't working plugin

Projects

None yet

Milestone

9.2.0

Development

Successfully merging this pull request may close these issues.

[Bug] mvc-annotation-commons NoSuchMethodError ServerHttpRequest.getMethodValue()

2 participants

Back | FazBrowse Home | New Git URL