Support for tracing webflux-6.x and gateway-4.x - #661
Conversation
Sorry, something went wrong.
| segments: | ||
| - segmentId: not null | ||
| spans: | ||
| - operationName: /provider/timeout/error |
There was a problem hiding this comment.
Is this timeout built intentionally?
Sorry, something went wrong.
There was a problem hiding this comment.
in order to check error case.
Sorry, something went wrong.
There was a problem hiding this comment.
My question is, are the codes causing the timeout on testing purpose?
Sorry, something went wrong.
There was a problem hiding this comment.
according to gateway3.x, in order to check request timeout case, so add the testcasse, issue
Sorry, something went wrong.
| segments: | ||
| - segmentId: not null | ||
| spans: | ||
| - operationName: /provider/timeout/error |
There was a problem hiding this comment.
Why is a timeout for entry? How an entry span timeout?
Sorry, something went wrong.
|
Could you confirm this #661 (comment)? If the codes don't seem to trigger error, we should not have them in the expected data. |
Sorry, something went wrong.
wu-sheng
left a comment
There was a problem hiding this comment.
Thanks for adding this.
Sorry, something went wrong.
Add support for spring-cloud-gateway 4.x
why:
spring-cloud-starter-gateway 4.0.0 depends on spring-boot-starter-webflux 3.0.0
spring-boot-starter-webflux 3.0.0 depends on spring-webflux 6.0.2
spring-webflux-5.x plugin can not trace the request
how:
add support for spring-webflux-6.x diff from 5.x by witnessmethod
upgrade spring-cloud-gateway to 4.x with spring-webflux-6.x diff from 3.x by witnessclass
Add an agent plugin to support spring-cloud-gateway 4.x
Add a test case for the new plugin, refer to the doc
Update the CHANGES log.