| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
Nice catch. But you have to verify all test cases work as expected. I notice we've declared many cleanups or teardowns. But they are actually not running at all. |
Sorry, something went wrong.
|
I think org.apache.skywalking.apm.agent.core.test.tools.TracingSegmentRunner#withAfters also needs to be modified. |
Sorry, something went wrong.
There was a problem hiding this comment.
Now I think all cleanup and teardown could work correctly, the code LGTM, thanks @JoeCqupt for your attentive discovery and don't forget to update CHANGES, let's wait for other teachers to review.
Sorry, something went wrong.
As no feature code change, no changelog required. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Fix
TracingSegmentRunner override method withAfters made Junit @after annotation not work