Fix problem which lead redisson plugin to throw unnecessary NullPointerException - #700
Merged
wu-sheng merged 5 commits intoJun 24, 2024
Merged
Fix problem which lead redisson plugin to throw unnecessary NullPointerException#700wu-sheng merged 5 commits into
wu-sheng merged 5 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
wu-sheng
reviewed
Jun 23, 2024
Comment thread
...main/java/org/apache/skywalking/apm/plugin/redisson/v3/RedisConnectionMethodInterceptor.java
Outdated
Comment on lines
+157
to
+164
| .stream() | ||
| .map(data -> data.getCommand().getName()) | ||
| .collect(Collectors.joining(";")); | ||
| .stream() | ||
| .map(data -> data.getCommand().getName()) | ||
| .collect(Collectors.joining(";")); |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
These seem unnecessary.
Sorry, something went wrong.
Comment thread
...main/java/org/apache/skywalking/apm/plugin/redisson/v3/RedisConnectionMethodInterceptor.java
Outdated
| AbstractSpan span = ContextManager.activeSpan(); | ||
| span.log(t); | ||
| public void handleMethodException(EnhancedInstance objInst, Method method, Object[] allArguments, Class<?>[] argumentsTypes, Throwable t, MethodInvocationContext context) { | ||
| if (ContextManager.isActive()) { |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
You should use flag here as well.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
ok, i fixed these two problems right now
Sorry, something went wrong.
wu-sheng
reviewed
Jun 23, 2024
Comment thread
...main/java/org/apache/skywalking/apm/plugin/redisson/v3/RedisConnectionMethodInterceptor.java
Outdated
…rg/apache/skywalking/apm/plugin/redisson/v3/RedisConnectionMethodInterceptor.java
wu-sheng
approved these changes
Jun 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change RedisConnectionInstrumentation and RedisConnectionMethodInterceptor to v2 interface, to solve the problem in this issue #693 .