support mongo ``db.instance`` tag、``db.collection`` tag and ``AggregateOperation`` span in mongodb-3.x-plugin and mongodb-4.x-plugin by youjie23 · Pull Request #728 · apache/skywalking-java · GitHub

support mongo db.instance tag、db.collection tag and AggregateOperation span in mongodb-3.x-plugin and mongodb-4.x-plugin

Please update the test scenario about mongodb. I need to see how the pipeline data looks like in the expectation file.

And your new changes break the plugin e2e tests. Please fix them.

And your new changes break the plugin e2e tests. Please fix them.

The Dead Link Checker / CheckDeadLinks ? :
[✖] https://research.google.com/pubs/pub36356.html → Status: 404

The Java-Plugin-Development-Guide.md is not in the changed files of this PR.
I'm not sure if changing it is the correct approach.
Should I ?

You don't need to worry that.

Your new testing cases seem not working well, need some fix.

Could you explain this? The more reflect we used, the more performance we impacted.

Thank you for the review. I have made the changes using SkyWalkingDynamicField based on your feedback.

…test scenarios and remove reflect

…test scenarios

Have you verified locally? It costs a lot to run CI repeatedly.

Have you verified locally? It costs a lot to run CI repeatedly.

Sorry for the trouble this problem has caused.
Actually，I have run the mongodb-3.x-scenario and mongodb-4.x-scenario projects after packaging the plugins with unit tests, and checked the produced data in the UI. What bothers me is that I often make silly mistakes, such as whitespace formatting errors in JSON strings, when manually editing the expectedData.yaml files.
Is manually editing the expectedData.yaml files an incorrect approach? Are there any other convenient approaches to avoid these problems or to detect them locally? If you could provide relevant operational documentation for reference, I would be very grateful.

UT is just for testing codes you wrote, but can't verify the runtime with the real library codes.

Plugin contribution docs step <5> includes how to run this locally, https://skywalking.apache.org/docs/skywalking-java/latest/en/setup/service-agent/java-agent/java-plugin-development-guide/#contribute-plugins-to-the-apache-skywalking-repository

https://skywalking.apache.org/docs/skywalking-java/latest/en/setup/service-agent/java-agent/plugin-test/#local-test-and-pull-request-to-the-upstream

Meanwhile, you missed the PR template, which guides you to check need-to-update document. In this case, you didn't update changes.md file

…n:code review

…lking-java into feature-mongo-support-fix

Meanwhile, you missed the PR template, which guides you to check need-to-update document. In this case, you didn't update changes.md file

Thank you for the review. Fixed that.

…n:code review

LGTM.

youjie_li added 2 commits November 22, 2024 03:11

support mongo db.instance and AggregateOperation

f8bf285

support mongo db.instance and AggregateOperation unit test

5801ee2

wu-sheng added plugin feature labels Nov 22, 2024

wu-sheng added this to the 9.4.0 milestone Nov 22, 2024

support mongo db.instance and AggregateOperation test scenarios

80b5ac8

youjie_li added 2 commits November 25, 2024 00:58

support mongo db.instance and AggregateOperation test scenarios

3e64803

support mongo db.instance and AggregateOperation test scenarios

4130d1f

youjie23 changed the title support mongo db.instance tag and AggregateOperation span in mongodb-3.x-plugin and mongodb-4.x-plugin support mongo db.instance tag、db.collection and AggregateOperation span in mongodb-3.x-plugin and mongodb-4.x-plugin Nov 24, 2024

wu-sheng reviewed Nov 25, 2024

View reviewed changes

youjie_li added 3 commits November 26, 2024 04:00

support mongo db.instance tag 、db.collection and AggregateOperation: …

12b4b04

…test scenarios and remove reflect

support mongo db.instance tag 、db.collection and AggregateOperation: …

13e6c50

…test scenarios

support mongo db.instance tag 、db.collection and AggregateOperation: …

2133699

…test scenarios

wu-sheng reviewed Nov 27, 2024

View reviewed changes

Comment thread ...lking/apm/plugin/mongodb/v3/interceptor/operation/OperationDatabaseConstructInterceptor.java

wu-sheng reviewed Nov 27, 2024

View reviewed changes

Comment thread ...ng/apm/plugin/mongodb/v3/interceptor/operation/WrappedMapReduceReadOperationInterceptor.java Outdated

Merge branch 'main' into feature-mongo-support-fix

9a7cec7

youjie23 changed the title support mongo db.instance tag、db.collection and AggregateOperation span in mongodb-3.x-plugin and mongodb-4.x-plugin support mongo db.instance tag、db.collection tag and AggregateOperation span in mongodb-3.x-plugin and mongodb-4.x-plugin Nov 27, 2024

youjie_li added 2 commits November 28, 2024 02:45

support mongo db.instance tag,db.collection tag and AggregateOperatio…

116c29a

…n:code review

Merge branch 'feature-mongo-support-fix' of github.com:youjie23/skywa…

d3b3ca2

…lking-java into feature-mongo-support-fix

wu-sheng reviewed Nov 28, 2024

View reviewed changes

Comment thread ...in/src/main/java/org/apache/skywalking/apm/plugin/mongodb/v4/support/MongoNamespaceInfo.java Outdated

wu-sheng reviewed Nov 28, 2024

View reviewed changes

Comment thread ...in/src/main/java/org/apache/skywalking/apm/plugin/mongodb/v4/support/MongoNamespaceInfo.java

wu-sheng reviewed Nov 28, 2024

View reviewed changes

Comment thread ...in/src/main/java/org/apache/skywalking/apm/plugin/mongodb/v4/support/MongoNamespaceInfo.java Outdated

support mongo db.instance tag,db.collection tag and AggregateOperatio…

6da22d9

…n:code review

wu-sheng approved these changes Nov 28, 2024

View reviewed changes

wu-sheng merged commit fc86413 into apache:main Nov 28, 2024

+                          if ("namespace".equals(field.getName())) {
+                              namespaceField = field;
+                              Field.setAccessible(new Field[]{field}, true);
+                          }
+                          if ("wrapped".equals(field.getName())) {
+                              wrappedField = field;
+                              Field.setAccessible(new Field[]{field}, true);
+                          }
+                          if ("databaseName".equals(field.getName())) {
+                              databaseField = field;
+                              Field.setAccessible(new Field[]{field}, true);
+                          }
+                          if ("collectionName".equals(field.getName())) {
+                              collectionField = field;
+                              Field.setAccessible(new Field[]{field}, true);
+                          }

support mongo ``db.instance`` tag、``db.collection`` tag and ``AggregateOperation`` span in mongodb-3.x-plugin and mongodb-4.x-plugin by youjie23 · Pull Request #728 · apache/skywalking-java · GitHub

Uh oh!

support mongo db.instance tag、db.collection tag and AggregateOperation span in mongodb-3.x-plugin and mongodb-4.x-plugin - #728

Conversation

youjie23 commented Nov 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wu-sheng commented Nov 22, 2024

Uh oh!

wu-sheng commented Nov 22, 2024

Uh oh!

youjie23 commented Nov 23, 2024

Uh oh!

wu-sheng commented Nov 23, 2024

Uh oh!

wu-sheng commented Nov 24, 2024

Uh oh!

wu-sheng Nov 25, 2024

Choose a reason for hiding this comment

Uh oh!

youjie23 Nov 25, 2024

Choose a reason for hiding this comment

Uh oh!

wu-sheng commented Nov 26, 2024

Uh oh!

youjie23 commented Nov 26, 2024

Uh oh!

wu-sheng commented Nov 26, 2024

Uh oh!

Uh oh!

Uh oh!

wu-sheng commented Nov 27, 2024

Uh oh!

youjie23 commented Nov 27, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wu-sheng left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

youjie23 commented Nov 22, 2024 •
edited
Loading