[Feature] Support for tracking in spring gateway versions 4.1.2 and above by yqw570994511 · Pull Request #747 · apache/skywalking-java · GitHub

Support for tracking in spring gateway versions 4.1.2 and above

…bove #12925

Why true? I can't see you override the args in the interceptor.

Why true? I can't see you override the args in the interceptor.

You are right, it should not be true

Error: error: unable to create file apm-sniffer/optional-plugins/optional-spring-plugins/optional-spring-cloud/gateway-4.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/spring/cloud/gateway/v412x/HttpClientFinalizerResponseConnectionV412Interceptor.java: Filename too long

It seems we face Windows limitations. Usually, we need to adjust the configuration of Windows.

…bove #12925

…ace_id' into feature_support_gateway_4.1.2_trace_id

Error: error: unable to create file apm-sniffer/optional-plugins/optional-spring-plugins/optional-spring-cloud/gateway-4.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/spring/cloud/gateway/v412x/HttpClientFinalizerResponseConnectionV412Interceptor.java: Filename too long

It seems we face Windows limitations. Usually, we need to adjust the configuration of Windows.

Will it affect the submission of this file?

The new added file seems to exceed length limitation.

The new added file seems to exceed length limitation.

How should we handle this issue? Should we modify it to a shorter file name? But I don't have a Windows environment to verify how suitable it is. Do you have any good suggestions

Error: error: unable to create file apm-sniffer/optional-plugins/optional-spring-plugins/optional-spring-cloud/gateway-4.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/spring/cloud/gateway/v412x/HttpClientFinalizerResponseConnectionV412Interceptor.java: Filename too long

It seems we face Windows limitations. Usually, we need to adjust the configuration of Windows.

@kezhenxu94 Do you have any recommendation to fix this in CI?

…bove #12925

…ace_id' into feature_support_gateway_4.1.2_trace_id

Error: error: unable to create file apm-sniffer/optional-plugins/optional-spring-plugins/optional-spring-cloud/gateway-4.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/spring/cloud/gateway/v412x/HttpClientFinalizerResponseConnectionV412Interceptor.java: Filename too long

It seems we face Windows limitations. Usually, we need to adjust the configuration of Windows.

@kezhenxu94 Do you have any recommendation to fix this in CI?

@yqw570994511 Can you please separate the command I added for windows only? Only add that command for windows platform. I'm not with my laptop now

Error: error: unable to create file apm-sniffer/optional-plugins/optional-spring-plugins/optional-spring-cloud/gateway-4.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/spring/cloud/gateway/v412x/HttpClientFinalizerResponseConnectionV412Interceptor.java: Filename too long

It seems we face Windows limitations. Usually, we need to adjust the configuration of Windows.

@kezhenxu94 Do you have any recommendation to fix this in CI?

@yqw570994511 Can you please separate the command I added for windows only? Only add that command for windows platform. I'm not with my laptop now

I'd love to help, but I'm not familiar with this and don't know how to operate it

Error: error: unable to create file apm-sniffer/optional-plugins/optional-spring-plugins/optional-spring-cloud/gateway-4.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/spring/cloud/gateway/v412x/HttpClientFinalizerResponseConnectionV412Interceptor.java: Filename too long

It seems we face Windows limitations. Usually, we need to adjust the configuration of Windows.

@kezhenxu94 Do you have any recommendation to fix this in CI?

@yqw570994511 Can you please separate the command I added for windows only? Only add that command for windows platform. I'm not with my laptop now

I'd love to help, but I'm not familiar with this and don't know how to operate it

Never mind. I've fixed it

@kezhenxu94 notice this

Invalid workflow file: .github/workflows/ci.yaml#L56
The workflow is not valid. .github/workflows/ci.yaml (Line: 56, Col: 13): Unexpected symbol: '"windows"'. Located at position 14 within expression: matrix.os == "windows"

[Feature] Support for tracking in spring gateway versions 4.1.2 and a…

d037668

…bove #12925

wu-sheng added plugin feature labels Jan 10, 2025

wu-sheng added this to the 9.4.0 milestone Jan 10, 2025

wu-sheng reviewed Jan 10, 2025

View reviewed changes

wu-sheng and others added 3 commits January 10, 2025 23:44

Merge branch 'main' into feature_support_gateway_4.1.2_trace_id

99e7362

[Feature] Support for tracking in spring gateway versions 4.1.2 and a…

eb1215f

…bove #12925

Merge remote-tracking branch 'origin/feature_support_gateway_4.1.2_tr…

ca97845

…ace_id' into feature_support_gateway_4.1.2_trace_id

kezhenxu94 and others added 7 commits January 11, 2025 11:56

long path support

3561363

Update ci.yaml

0e5e356

[Feature] Support for tracking in spring gateway versions 4.1.2 and a…

e9cb47d

…bove #12925

Merge remote-tracking branch 'origin/feature_support_gateway_4.1.2_tr…

360de70

…ace_id' into feature_support_gateway_4.1.2_trace_id

Update ci.yaml

cfccb66

Merge remote-tracking branch 'origin/feature_support_gateway_4.1.2_tr…

695e503

…ace_id' into feature_support_gateway_4.1.2_trace_id

Update ci.yaml

bcf8fb6

Update ci.yaml

8215ab5

Update ci.yaml

a73ff88

wu-sheng approved these changes Jan 11, 2025

View reviewed changes

wu-sheng merged commit 3549537 into apache:main Jan 11, 2025

happier2 mentioned this pull request Aug 29, 2025

[Bug] Spring Cloud Gateway plugin causes traceIds duplicated with different requests apache/skywalking#13443

Closed

3 tasks

[Feature] Support for tracking in spring gateway versions 4.1.2 and above by yqw570994511 · Pull Request #747 · apache/skywalking-java · GitHub

Uh oh!

[Feature] Support for tracking in spring gateway versions 4.1.2 and above - #747

[Feature] Support for tracking in spring gateway versions 4.1.2 and above#747
wu-sheng merged 13 commits into
apache:mainfrom
yqw570994511:feature_support_gateway_4.1.2_trace_id

yqw570994511 commented Jan 10, 2025

Uh oh!

wu-sheng Jan 10, 2025

Uh oh!

yqw570994511 Jan 10, 2025

Uh oh!

wu-sheng commented Jan 10, 2025

Uh oh!

yqw570994511 commented Jan 10, 2025

Uh oh!

wu-sheng commented Jan 10, 2025

Uh oh!

yqw570994511 commented Jan 10, 2025

Uh oh!

wu-sheng commented Jan 11, 2025

Uh oh!

kezhenxu94 commented Jan 11, 2025

Uh oh!

yqw570994511 commented Jan 11, 2025

Uh oh!

kezhenxu94 commented Jan 11, 2025

Uh oh!

wu-sheng commented Jan 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

+                              @Override
+                              public boolean isOverrideArgs() {
+                                  return true;

[Feature] Support for tracking in spring gateway versions 4.1.2 and above by yqw570994511 · Pull Request #747 · apache/skywalking-java · GitHub

Uh oh!

[Feature] Support for tracking in spring gateway versions 4.1.2 and above - #747

Conversation

yqw570994511 commented Jan 10, 2025

Uh oh!

wu-sheng Jan 10, 2025

Choose a reason for hiding this comment

Uh oh!

yqw570994511 Jan 10, 2025

Choose a reason for hiding this comment

Uh oh!

wu-sheng commented Jan 10, 2025

Uh oh!

yqw570994511 commented Jan 10, 2025

Uh oh!

wu-sheng commented Jan 10, 2025

Uh oh!

yqw570994511 commented Jan 10, 2025

Uh oh!

wu-sheng commented Jan 11, 2025

Uh oh!

kezhenxu94 commented Jan 11, 2025

Uh oh!

yqw570994511 commented Jan 11, 2025

Uh oh!

kezhenxu94 commented Jan 11, 2025

Uh oh!

wu-sheng commented Jan 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants