FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix ConsumeDriver running status by JoeCqupt · Pull Request #748 · apache/skywalking-java · GitHub

/ skywalking-java Public

Fix ConsumeDriver running status - #748

Merged
wu-sheng merged 3 commits into
apache:mainfrom
JoeCqupt:main
Jan 19, 2025
ConversationCommits (3)ChecksFiles changed
Merged

Fix ConsumeDriver running status#748
wu-sheng merged 3 commits into
apache:mainfrom
JoeCqupt:main

Conversation

JoeCqupt commented Jan 17, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
  • Update the CHANGES log.

wu-sheng commented Jan 17, 2025

Copy link
Copy Markdown
Member

Could you explain why do this change?

JoeCqupt commented Jan 18, 2025
View reviewed changes
Comment thread ...rier/src/main/java/org/apache/skywalking/apm/commons/datacarrier/consumer/ConsumeDriver.java Outdated
}
lock.lock();
try {
if (running){

JoeCqupt Jan 18, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Double Checked Locking

JoeCqupt commented Jan 18, 2025

Copy link
Copy Markdown
Contributor Author

ConsumeDriver use a lock + running status to protect begin method. but there is a problem with code. it should use Double Checked Locking

wu-sheng commented Jan 18, 2025

Copy link
Copy Markdown
Member

ConsumeDriver use a lock + running status to protect begin method. but there is a problem with code. it should use Double Checked Locking

Did you face some issues? Could you paste the logs here?
Or just from code review perspective?

wu-sheng added the bug Something isn't working label Jan 18, 2025
wu-sheng added this to the 9.4.0 milestone Jan 18, 2025

wu-sheng commented Jan 18, 2025

Copy link
Copy Markdown
Member

You should update changes.md and describe what is fixed.

wu-sheng commented Jan 18, 2025

Copy link
Copy Markdown
Member

You should update changes.md and describe what is fixed.

CI seems strange. Please update this and push again.

JoeCqupt commented Jan 18, 2025

Copy link
Copy Markdown
Contributor Author

ConsumeDriver use a lock + running status to protect begin method. but there is a problem with code. it should use Double Checked Locking

Did you face some issues? Could you paste the logs here? Or just from code review perspective?

I just found it when I am studying the skywalking-java source code

wu-sheng commented Jan 18, 2025

Copy link
Copy Markdown
Member

It seems you broke the code style, please check before submit.

wu-sheng merged commit affbaa8 into apache:main Jan 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

wu-sheng wu-sheng approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

9.4.0

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL