FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add the virtual thread executor plugin by peachisai · Pull Request #751 · apache/skywalking-java · GitHub

/ skywalking-java Public

Add the virtual thread executor plugin - #751

Merged
wu-sheng merged 6 commits into
apache:mainfrom
peachisai:uat
Mar 9, 2025
ConversationCommits (6)ChecksFiles changed
Merged

Add the virtual thread executor plugin#751
wu-sheng merged 6 commits into
apache:mainfrom
peachisai:uat

Conversation

peachisai commented Mar 8, 2025

Copy link
Copy Markdown
Member
  • If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
  • Update the CHANGES log.

wu-sheng reviewed Mar 8, 2025
View reviewed changes
Comment thread ...etwork/src/main/java/org/apache/skywalking/apm/network/trace/component/ComponentsDefine.java

public static final OfficialComponent CAFFEINE = new OfficialComponent(160, "Caffeine");

public static final OfficialComponent THREAD_PER_TASK_EXECUTOR = new OfficialComponent(161, "ThreadPerTask-executor");

wu-sheng Mar 8, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

ID submitted through apache/skywalking#13090

wu-sheng added this to the 9.5.0 milestone Mar 8, 2025
wu-sheng reviewed Mar 8, 2025
View reviewed changes
Comment thread ...ffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/tag/Tags.java Outdated
Comment on lines +159 to +161
* CARRIER_THREAD represents the actual operating system thread that carries out the execution of the virtual thread.
*/
public static final StringTag CARRIER_THREAD = new StringTag(24, "carrier.thread");

wu-sheng Mar 8, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

To follow the naming style, I think the thread.carrier is better?

peachisai Mar 8, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

To follow the naming style, I think the thread.carrier is better?

Yes, better, done.

wu-sheng commented Mar 8, 2025

Copy link
Copy Markdown
Member

Could you try to fix the deadlink? I think the previous link is pointing to very old repo, which should be changed to skywalking asf main repo.

peachisai commented Mar 8, 2025

Copy link
Copy Markdown
Member Author

Could you try to fix the deadlink? I think the previous link is pointing to very old repo, which should be changed to skywalking asf main repo.

Done.

wu-sheng reviewed Mar 9, 2025
View reviewed changes
Comment thread apm-sniffer/bootstrap-plugins/jdk-virtual-thread-executor-plugin/pom.xml
Comment on lines +38 to +44
<build>
<plugins>
<plugin>
<artifactId>maven-deploy-plugin</artifactId>
</plugin>
</plugins>
</build>

wu-sheng Mar 9, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Could you check whether your new module could generate javadoc jar? Another plugin pom.xml has relative configurations to generate that file.

peachisai Mar 9, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Could you check whether your new module could generate javadoc jar? Another plugin pom.xml has relative configurations to generate that file.

When I added the maven-javadoc-plugin, I could generate the javadoc.jar

wu-sheng Mar 9, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Please add that plugin, otherwise, this will fail the release process.

wu-sheng approved these changes Mar 9, 2025
View reviewed changes

wu-sheng left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

wu-sheng merged commit 35856b4 into apache:main Mar 9, 2025
peachisai deleted the uat branch March 9, 2025 02:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

wu-sheng wu-sheng approved these changes

Assignees

No one assigned

Labels

feature plugin

Projects

None yet

Milestone

9.5.0

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL