To prevent NPE use pool name for metrics if JDBC URL is not set. - #754
Merged
wu-sheng merged 2 commits intoMay 7, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Please provide the demo codes to represent two ways of using. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
@wu-sheng How should I do this? https://github.com/brettwooldridge/HikariCP/?tab=readme-ov-file#rocket-initialization HikariConfig config = new HikariConfig();
config.setJdbcUrl("jdbc:mysql://localhost:3306/simpsons");
or using data source properties Properties props = new Properties();
props.setProperty("dataSourceClassName", "org.postgresql.ds.PGSimpleDataSource");
props.setProperty("dataSource.serverName", "localhost");
...
HikariConfig config = new HikariConfig(props);
HikariDataSource ds = new HikariDataSource(config)
|
Sorry, something went wrong.
wu-sheng
approved these changes
May 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix NPE
java.lang.NullPointerException: Cannot invoke "String.toLowerCase()" because "url" is null at org.apache.skywalking.apm.plugin.jdbc.connectionurl.parser.URLParser.parser(URLParser.java:47) at org.apache.skywalking.apm.plugin.hikaricp.PoolingSealInterceptor.afterMethod(PoolingSealInterceptor.java:52) at org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstMethodsInter.intercept(InstMethodsInter.java:110) at com.zaxxer.hikari.HikariDataSource.seal(HikariDataSource.java) at com.zaxxer.hikari.HikariDataSource.$sw$original$getConnection$08spks0(HikariDataSource.java:112) at com.zaxxer.hikari.HikariDataSource.$sw$original$getConnection$08spks0$accessor$$sw$6kb3bn3(HikariDataSource.java) at com.zaxxer.hikari.HikariDataSource$$sw$auxiliary$93993q0.call(Unknown Source) at org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstMethodsInter.intercept(InstMethodsInter.java:95)The pool can be configured with data source options but not JDBC URL so in this case we can use pool name for metrics.