Bump up apache parent pom to v35. - #771
Conversation
…et rid of --release in JDK compiling.
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Apache parent POM from version 21 to version 35 and upgrades the Maven wrapper to version 3.6.3. The changes standardize Java compilation settings across the project by leveraging the parent POM's configuration and removing redundant property declarations.
- Upgrades Apache parent POM from v21 to v35
- Updates Maven wrapper from 3.6.1 to 3.6.3
- Consolidates Java compiler settings and removes duplicate property declarations
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file| File | Description |
|---|---|
| pom.xml | Updates Apache parent POM version and adds standardized Java compiler properties |
| .mvn/wrapper/maven-wrapper.properties | Updates Maven wrapper to version 3.6.3 |
| test/plugin/scenarios/micronaut-http-scenario/pom.xml | Removes redundant Java compiler properties |
| apm-sniffer/bootstrap-plugins/jdk-http-plugin/pom.xml | Adds compiler release property override |
| apm-sniffer/apm-sdk-plugin/finagle-6.25.x-plugin/pom.xml | Removes duplicate compiler source/target properties |
| apm-sniffer/apm-sdk-plugin/elasticsearch-5.x-plugin/pom.xml | Removes duplicate Java version properties |
| CHANGES.md | Documents the version updates |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sorry, something went wrong.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
| <!-- Reset this to the blank value to avoid using -release in JDK compiling --> | ||
| <maven.compiler.release></maven.compiler.release> |
There was a problem hiding this comment.
This is intentional. Refer to Maven doc,
Starting with JDK 9, the javac executable can accept the --release option to specify against which Java SE release you want to build the project. For example, you have JDK 11 installed and used by Maven, but you want to build the project against Java 8. The --release option ensures that the code is compiled following the rules of the programming language of the specified release, and that generated classes target the release as well as the public API of that release. This means that, unlike the old -source and -target options, the compiler will detect and generate an error when using APIs that don't exist in previous releases of Java SE.
Sorry, something went wrong.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.