[TIKA-4841] Add unit tests for Metadata reserved-key blocking, write limiter, and composite properties - #2948
Merged
THausherr merged 10 commits intoAug 26, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
vasiliy-mikhailov
force-pushed
the
ijt-pr/e72199f
branch
from
6917198 to
99fb891
Compare
July 12, 2026 08:21
Copy link
Copy Markdown
Contributor
|
I looked at it without AI and it makes sense. Lets see what copilot thinks about it. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull request overview
Adds focused JUnit tests in tika-core to increase behavioral coverage of org.apache.tika.metadata.Metadata, especially around reserved X-TIKA: key guarding and MetadataWriteLimiter delegation semantics.
Changes:
- Added new unit tests asserting Metadata.equals differs when values differ under the same key.
- Added tests for reserved-key blocking on untrusted metadata vs allowing writes after setTrusted(true).
- Added tests for MetadataWriteLimiter behavior, including “block all” and verifying delegation for set(...) overloads, plus small in-test limiter implementations.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sorry, something went wrong.
Comment on lines
+564
to
+572
| @Test | ||
| public void testWriteLimiterInvokedOnSetProperty() { | ||
| RecordingLimiter limiter = new RecordingLimiter(); | ||
| Metadata m = new Metadata(limiter); | ||
| m.set(TikaCoreProperties.TITLE, "title"); | ||
| assertTrue(limiter.setCalled); | ||
| assertEquals(TikaCoreProperties.TITLE.getName(), limiter.lastSetField); | ||
| assertEquals("title", limiter.lastSetValue); | ||
| } |
Update test for reserved keys in untrusted Metadata.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Results
Scope: module tika-core, target production class org.apache.tika.metadata.Metadata, tests org.apache.tika.metadata.TestMetadata. Measured with PIT 1.15.2 (junit5 plugin) under JDK 17, clean test-compile forced before each run.
The added tests kill 4 additional Metadata mutants and eliminate 2 survivors.
What this adds
Six focused unit tests on Metadata, each asserting observable behavior or a documented contract:
Scope
Tests-only. One file changed: tika-core/src/test/java/org/apache/tika/metadata/TestMetadata.java (121 insertions, 0 deletions vs base). No production code, no fixtures, no build changes; Apache license headers unchanged.
Disclosure
This PR was generated with an AI-assisted pipeline built around mutation testing (PIT). The pipeline mutates the target class (flipping conditions and changing boundary/edge cases) and runs the existing tests against each mutant; where a mutant survives (the existing tests do not catch that edge case), it writes a focused test for that case and reruns PIT to confirm the new test actually kills that specific mutant.