This PR improves test coverage for the storeconfig module by adding
unit tests for core classes that previously had little to no test
coverage.
Motivation
While analyzing overall test coverage, the storeconfig module was
identified as one of the largest gaps, with many untested classes.
These classes are responsible for configuration serialization and
XML generation, making them important for reliability.
This PR introduces targeted tests to cover core behaviors, edge cases,
and failure scenarios across the module.
Changes
StoreDescription
Added TestStoreDescription covering:
Getters and setters
Transient attributes and child handling
Identifier and attribute resolution
StoreRegistry
Added TestStoreRegistry covering:
Registration and unregistration of descriptions
Lookup and factory resolution
Handling of missing or invalid classes
StoreAppender
Added TestStoreAppender covering:
XML tag generation
Attribute and value printing
Indentation and formatting behavior
Handling of arrays and nested elements
StoreFactoryBase
Added TestStoreFactoryBase covering:
Storing elements with and without descriptors
Appender and registry interaction
XML generation entry points
StoreFileMover
Added TestStoreFileMover covering:
File rotation and rename logic
Writer creation and handling
Failure scenarios and edge cases
Property getters and setters
Testing
All tests pass locally:
ant clean test
Targeted validation performed for each new test class with no failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves test coverage for the storeconfig module by adding
unit tests for core classes that previously had little to no test
coverage.
Motivation
While analyzing overall test coverage, the storeconfig module was
identified as one of the largest gaps, with many untested classes.
These classes are responsible for configuration serialization and
XML generation, making them important for reliability.
This PR introduces targeted tests to cover core behaviors, edge cases,
and failure scenarios across the module.
Changes
StoreDescription
Added TestStoreDescription covering:
StoreRegistry
Added TestStoreRegistry covering:
StoreAppender
Added TestStoreAppender covering:
StoreFactoryBase
Added TestStoreFactoryBase covering:
StoreFileMover
Added TestStoreFileMover covering:
Testing
All tests pass locally:
Targeted validation performed for each new test class with no failures.
Test results:
Coverage Impact
This PR significantly improves coverage for the storeconfig module,
which previously had minimal test coverage.
Core classes are now covered, including:
This establishes a strong foundation for further coverage improvements
in remaining classes.
Impact
Files Changed
Notes
This PR is part of ongoing work to systematically improve test
coverage across Tomcat modules, focusing on high-impact gaps.
Checklist