Support multiple field projection, by names and indexes for Pojo (#649) - #710
Open
JunWang222 wants to merge 1 commit into
Open
JunWang222 wants to merge 1 commit into
JunWang222 wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
- Add MultiFieldPojoImplementation static class following the existing PojoImplementation and RecordImplementation pattern - Add createForPojoByNames() factory for projecting multiple POJO fields by name into a Record - Add createForPojoByIndexes() factory for projecting POJO fields by their declared index into a Record - Restore RecordImplementation and createRecordJavaImplementation for consistency with the original codebase style - Add 9 new tests covering multi-field by name, by index, field reordering, null values, out-of-bounds, and nonexistent field error cases
Copy link
Copy Markdown
Contributor
|
@zkaoudi I see you asked me for review, what's the intended usage here for POJOs? I think implementation in the PR is fine but I have some concerns about the type system, in the PR we wrap the output in Record but I assume that the output of the operator also wraps in Record would this be intended behaviour? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Hi, would it be possible for you to implement an integration test for you multi POJOs? |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
At least 1 approving review is required to merge this pull request.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue#649 Revise implementation to support multiple field projection, by names
Plan
Add a new MultiFieldPojoImplementation class following the same pattern as the existing PojoImplementation and RecordImplementation. It takes multiple field names, extracts each field from the input POJO via reflection, and packs the values into a Record.
Expose it through two new factory methods — one for field names, one for indexes — and keep the existing single-field path untouched for backward compatibility. The existing constructor routes automatically: