WAYANG-678: Implement cardinality tracking in DataStreamChannel - #729
Open
Harshakamalur wants to merge 1 commit into
Open
Harshakamalur wants to merge 1 commit into
Harshakamalur wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
Hi @apache/wayang-committers, I've now submitted two PRs: this one for the README links and #728 for the TensorFlow test fixes. Could you please assign both to me and approve the CI workflows so I can ensure all tests pass? Thanks! |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Can you also provide an integration test for getting the cardinality? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@Harshakamalur - dod you see the latest comment from @mspruc ? |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
At least 1 approving review is required to merge this pull request.
Assignees
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #678.
Implements cardinality tracking in DataStreamChannel.Instance using AtomicLong, following the same pattern as RddChannel in the Spark platform.
Changes:
All 25 existing Flink tests pass.