vitest.shell.config.mts declares no resolve.alias, and Vite does not read the paths block in tsconfig.base.json, so a spec cannot reach application source:
Failed to resolve import "@zeppelin/interfaces" from "src/app/services/array-ordering.service.ts"
The failure is in the source, not the spec: most of src/ imports @zeppelin/* itself, so a relative import does not avoid it.
monaco-editor does not resolve either. It publishes no main and no exports (monaco-editor#4848); module names editor.main, which boots the full editor and fails under jsdom. Eleven files import it, two behind the @zeppelin/services barrel.
This adds the alias block, a spec that exercises it, and a note in AGENTS.md. Two entries differ from tsconfig.base.json:
@zeppelin/sdk and @zeppelin/visualization resolve to library source, not dist/, so a unit run does not wait on a build. projects/zeppelin-react/vitest.config.mts already does this for the SDK.
monaco-editor resolves to esm/vs/editor/editor.api.js.
npm run test:shell goes from 29 tests to 37. The new spec covers ArrayOrderingService: trash folder last, blank title falls back to Note <id>, folders before notes, same-kind nodes by display name.
It imports through the @zeppelin/services barrel so the chain reaches monaco and @zeppelin/sdk. Pointing any of monaco-editor, @zeppelin/sdk or the catch-all at a nonexistent path fails it. Nothing imports the sdk/* or visualization/* subpaths today, so those two are uncovered.
ng build --configuration production and ng lint both pass unchanged: only Vitest reads the config, and src/tsconfig.json excludes specs from the build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
vitest.shell.config.mts declares no resolve.alias, and Vite does not read the paths block in tsconfig.base.json, so a spec cannot reach application source:
The failure is in the source, not the spec: most of src/ imports @zeppelin/* itself, so a relative import does not avoid it.
monaco-editor does not resolve either. It publishes no main and no exports (monaco-editor#4848); module names editor.main, which boots the full editor and fails under jsdom. Eleven files import it, two behind the @zeppelin/services barrel.
This adds the alias block, a spec that exercises it, and a note in AGENTS.md. Two entries differ from tsconfig.base.json:
What type of PR is it?
Improvement
Todos
None
What is the Jira issue?
ZEPPELIN-6685
How should this be tested?
npm run test:shell goes from 29 tests to 37. The new spec covers ArrayOrderingService: trash folder last, blank title falls back to Note <id>, folders before notes, same-kind nodes by display name.
It imports through the @zeppelin/services barrel so the chain reaches monaco and @zeppelin/sdk. Pointing any of monaco-editor, @zeppelin/sdk or the catch-all at a nonexistent path fails it. Nothing imports the sdk/* or visualization/* subpaths today, so those two are uncovered.
ng build --configuration production and ng lint both pass unchanged: only Vitest reads the config, and src/tsconfig.json excludes specs from the build.
Screenshots (if appropriate)
N/A
Questions: