FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore(dependabot): add dependabot by sad270 · Pull Request #5947 · api-platform/core · GitHub

/ core Public

chore(dependabot): add dependabot - #5947

Merged
dunglas merged 1 commit into
api-platform:3.1from
sad270:chore/add-dependabot
Nov 6, 2023
ConversationCommits (1)ChecksFiles changed
Merged

chore(dependabot): add dependabot#5947
dunglas merged 1 commit into
api-platform:3.1from
sad270:chore/add-dependabot

Conversation

sad270 commented Nov 4, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor
Q A
Branch? 3.1
Tickets
License MIT
Doc PR

Add dependabot to update github actions.

Configuration is comming from https://github.com/api-platform/api-platform/blob/main/.github/dependabot.yml

soyuka commented Nov 5, 2023

Copy link
Copy Markdown
Member

we're using our own update-js script there is no package-lock on this project I think

sad270 commented Nov 5, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Hello, i'm maybe wrong but update-js will update js packages, in this PR dependabot will update github action uses.

sad270 commented Nov 5, 2023

Copy link
Copy Markdown
Contributor Author

In #5946 I did it manually 😅 but if it is automatically updated it will be better ! With dependabot or with another tool.

dunglas approved these changes Nov 6, 2023
View reviewed changes
Comment thread .github/dependabot.yml Outdated

dunglas commented Nov 6, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

By the way, as we keep the yarn.lock file, we may also replace update-js.js by Dependabot (in a next PR).

sad270 force-pushed the chore/add-dependabot branch from 257df11 to 9cbd494 Compare November 6, 2023 09:18

dunglas commented Nov 6, 2023

Copy link
Copy Markdown
Member

One last thing: this should target the 3.1 branch

sad270 changed the base branch from main to 3.1 November 6, 2023 12:23
sad270 changed the base branch from 3.1 to main November 6, 2023 12:23
sad270 force-pushed the chore/add-dependabot branch from 9cbd494 to db3c37d Compare November 6, 2023 16:50
sad270 changed the base branch from main to 3.1 November 6, 2023 16:51

sad270 commented Nov 6, 2023

Copy link
Copy Markdown
Contributor Author

One last thing: this should target the 3.1 branch

@dunglas target changed it's 3.1 now 😄

dunglas merged commit c617b18 into api-platform:3.1 Nov 6, 2023

dunglas commented Nov 6, 2023

Copy link
Copy Markdown
Member

Thank you!!

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dunglas dunglas approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL