httpsurlconn quickstart message-signing integration - #4
Open
charlesoj6205 wants to merge 2 commits into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
…line with updates to HttpsURLConn service layer. V5 endpoint tested successfully. Instructional files within quickstart require further updates. Reverted quickstart to original V1 state with installation message signing changes commented out.
Copy link
Copy Markdown
There was a problem hiding this comment.
Pull request overview
Updates the Android “Shapes App” quickstart to integrate the approov-service httpsurlconn module and provide commented reference wiring for installation message-signing, while tweaking request behavior to better support signed targets.
Changes:
- Switches the build to include an :approov-service module and depend on it from the app.
- Adds commented reference code for Approov installation message-signing integration in ShapesApp.
- Disables automatic redirects for the shapes request to avoid redirect-induced signature invalidation.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| shapes-app/settings.gradle | Adds :approov-service module inclusion and maps it to a local directory |
| shapes-app/app/build.gradle | Raises minSdkVersion and adds dependency on :approov-service |
| shapes-app/app/src/main/java/io/approov/shapes/ShapesApp.java | Adds commented imports and commented message-signing setup; updates example initialization line |
| shapes-app/app/src/main/java/io/approov/shapes/MainActivity.java | Disables redirect following for the shapes request |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sorry, something went wrong.
Comment thread
shapes-app/settings.gradle
| //include ':approov-sdk' | ||
| include ':app' | ||
| include ':approov-service' | ||
| project(':approov-service').projectDir = new File('/Users/charlesoj/Developer/Quickstarts/approov-service-httpsurlconn/approov-service') |
Comment thread
shapes-app/app/src/main/java/io/approov/shapes/ShapesApp.java
Outdated
Comment on lines
+208
to
210
| // Keep the originally signed request target unchanged (redirects can invalidate signatures). | ||
| connection.setInstanceFollowRedirects(false); | ||
| connection.addRequestProperty("Api-Key", getResources().getString(R.string.shapes_api_key)); |
Comment thread
shapes-app/app/build.gradle
| defaultConfig { | ||
| applicationId "io.approov.shapes" | ||
| minSdkVersion 21 | ||
| minSdkVersion 23 |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates quickstart integration work; keeps v1 runtime behavior with v5/message-signing changes commented for reference.