FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Files sort add unique order to createAt by fogelito · Pull Request #13155 · appwrite/appwrite · GitHub

/ appwrite Public

Files sort add unique order to createAt - #13155

Open
fogelito wants to merge 3 commits into
mainfrom
file-sorting
ConversationCommits (3)ChecksFiles changed
Open

Files sort add unique order to createAt#13155
fogelito wants to merge 3 commits into
mainfrom
file-sorting

Conversation

fogelito commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

(Provide a description of what this PR does and why it's needed.)

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Screenshots may also be helpful.)

Related PRs and Issues

  • (Related PR or issue)

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

greptile-apps Bot commented Aug 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR makes descending file creation-time sorting deterministic by adding a descending sequence tie-breaker.

  • Detects a sole descending $createdAt order.
  • Adds $sequence DESC before resolving cursor pagination and querying bucket files.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
src/Appwrite/Platform/Modules/Storage/Http/Buckets/Files/XList.php Adds a descending sequence tie-breaker to file listings ordered solely by descending creation time; no eligible follow-up finding was established.

Reviews (3): Last reviewed commit: "Update comment" | Re-trigger Greptile

github-actions Bot commented Aug 9, 2026 •
edited
Loading

Copy link
Copy Markdown

✨ Benchmark results

Comparing main (before) → file-sorting (after).

Metric Before After Change
🚀 Requests/sec 204.44 203.44 ⚪ -0.5%
⏱️ Latency P50 70.98 ms 71.61 ms ⚪ +0.9%
⏱️ Latency P95 237.99 ms 238.33 ms ⚪ +0.1%
Per-scenario breakdown & investigation details

Metrics below reflect the current branch (after). Δ P95 compares against the base.

Scenario P50 (ms) P95 (ms) Requests RPS Δ P95 (ms)
API total 71.61 238.33 12,654 203.44 +0.33
Account 131.11 332.52 666 11.16 +5.35
TablesDB 67.84 218.08 6,882 112.41 +2.83
Storage 66.3 224.21 3,330 56.13 +0.58
Functions 109.49 293.68 1,776 30.58 -2.45

Top API waits (after)

API request Max wait (ms)
functions.runtimes.list 882.26
tablesdb.rows.create 715.51
storage.files.delete 660.66
functions.variables.get 639.23
tablesdb.rows.update 602.83

HarshMN2345 mentioned this pull request Aug 10, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

Back | FazBrowse Home | New Git URL