test: add unit tests for ClassicRAG chunk distribution and token budg… - #2681
Open
ManasKumar111 wants to merge 1 commit into
Open
ManasKumar111 wants to merge 1 commit into
ManasKumar111 wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
|
@ManasKumar111 is attempting to deploy a commit to the Arc53 Team on Vercel. A member of the Team first needs to authorize it. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds unit tests for ClassicRAG._get_data() covering chunk distribution, token budget enforcement, and the base_chunks override behavior — previously untested logic in application/retriever/classic_rag.py.
Tests added
Why
No test file existed for classic_rag.py. This logic governs how many documents actually reach the LLM prompt, so incorrect behavior here directly affects retrieval quality.
How tested
All 5 tests run and passing inside the Docker backend container:
docker compose -f deployment/docker-compose.yaml exec backend python3 -m pytest tests/retriever/test_classic_rag.py -v
Result: 5 passed, 0 failed
Type of change