Repository navigation
Move matrixmarket downloads to build stage - #2742
Merged
umar456 merged 1 commit intoFeb 7, 2020
Merged
umar456 merged 1 commit into
umar456 merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
umar456
reviewed
Feb 6, 2020
Comment thread
test/CMakeModules/download_sparse_datasets.cmake
| # Following files are used for testing mtx read fn | ||
| # integer data | ||
| download_mtx("Trec4" "JGD_Kocay") | ||
| mtxDownload("Trec4" "JGD_Kocay") |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Could you use the original file names directly instead of putting it in a "group"? That way there will be less obfuscation.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
The grouping is not introduced in our code. The mtx files are organized in that manner: files under different groups can have identical names. The tar file download URL also follows the same convention.
Sorry, something went wrong.
umar456
approved these changes
Feb 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.