Repository navigation
Make cudnn dependency optional - #2836
umar456 merged 5 commits into
Conversation
Sorry, something went wrong.
There was a problem hiding this comment.
Some style and code organization changes are needed.
I think it would it be beneficial if we just use the non cuDNN implementation as fallback when cuDNN isn't available at runtime.
We can just rename the convolveNN_base.cpp file as convolveNN_fallback.cpp and avoid the cmake changes (extra WITH_CUDNN definition and all cascading changes due to addition of WITH_CUDNN) completely.
Also, please fix the formatting too.
Sorry, something went wrong.
There was a problem hiding this comment.
Looks good. I am re-running the one failed job (ci/win-cuda-k5000), will merge once it goes green.
Sorry, something went wrong.
* adds fallback for convolveNN functions * adds cudnn option, runtime fallback * Noexcept and const many Dependency module functions * Refactor cuDNN code in CMake * Fix fallback logic. refactor cuDNN util functions. Fix f16 wrap Co-authored-by: Umar Arshad <umar@arrayfire.com>
* adds fallback for convolveNN functions * adds cudnn option, runtime fallback * Noexcept and const many Dependency module functions * Refactor cuDNN code in CMake * Fix fallback logic. refactor cuDNN util functions. Fix f16 wrap Co-authored-by: Umar Arshad <umar@arrayfire.com>
This PR removes the need for an installed cuDNN library when building ArrayFire.
The new fallback methods match those in the opencl backend and determine the gradients through the wrap/unwrap methods.