FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix empty array handling in lu, rank, and qr. Other minor refactoring by umar456 · Pull Request #2838 · arrayfire/arrayfire · GitHub

  1. arrayfire
  2. arrayfire

Repository navigation

Fix empty array handling in lu, rank, and qr. Other minor refactoring - #2838

Merged
umar456 merged 4 commits into
arrayfire:masterfrom
umar456:empty_fix
Apr 13, 2020
ConversationCommits (4)ChecksFiles changed
Merged

Fix empty array handling in lu, rank, and qr. Other minor refactoring#2838
umar456 merged 4 commits into
arrayfire:masterfrom
umar456:empty_fix

Conversation

umar456 commented Apr 11, 2020

Copy link
Copy Markdown
Member
  • some linear algebra functions could have leaked memory in case the input was null. This PR addresses that potential leak and handles the empty or null array case.
  • Minor refactor in median
  • Minor refactor in DefaultMemoryManager. Just changed names of the variables.

umar456 added this to the 3.7.2 milestone Apr 11, 2020
9prady9 requested changes Apr 11, 2020
View reviewed changes

9prady9 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Please also fix the formatting problem in the following files:
test/memory.cpp
test/median.cpp

Comment thread src/api/c/lu.cpp
Comment thread test/lu_dense.cpp Outdated
Comment thread src/backend/common/DefaultMemoryManager.cpp
Comment thread src/backend/common/DefaultMemoryManager.cpp
Comment thread src/backend/common/DefaultMemoryManager.cpp Outdated
Comment thread src/backend/common/DefaultMemoryManager.cpp Outdated
Comment thread src/backend/common/DefaultMemoryManager.cpp Outdated
Comment thread src/api/c/median.cpp
Comment thread test/median.cpp
umar456 requested a review from 9prady9 April 12, 2020 16:32
9prady9 requested changes Apr 13, 2020
View reviewed changes

9prady9 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Memory leaks in all new tests for lu_dense.cpp, qr_dense.cpp and rank_dense.cpp. I believe that is why the ASAN tests failed.

Also, the formatting is still off in test/memory.cpp file.

umar456 requested a review from 9prady9 April 13, 2020 10:59

umar456 commented Apr 13, 2020

Copy link
Copy Markdown
Member Author

Addressed all feedback

umar456 merged commit 2e098d4 into arrayfire:master Apr 13, 2020
9prady9 deleted the empty_fix branch April 13, 2020 13:29
umar456 mentioned this pull request Jun 27, 2020
Merged
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

9prady9 9prady9 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.7.2

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL