Repository navigation
Apply clang-tidy suggestions to all backends - #2839
Merged
9prady9 merged 13 commits intoApr 15, 2020
Merged
9prady9 merged 13 commits into
9prady9 merged 13 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
9prady9
requested changes
Apr 13, 2020
Comment thread
src/api/c/blas.cpp
Comment thread
src/api/c/canny.cpp
Comment thread
src/api/c/confidence_connected.cpp
Comment thread
src/api/c/random.cpp
Comment thread
src/api/c/stdev.cpp
Comment thread
src/api/c/transform.cpp
Comment thread
src/backend/cuda/nvrtc/cache.hpp
Outdated
Comment thread
src/backend/opencl/clfft.cpp
Comment thread
src/backend/opencl/math.hpp
Outdated
Comment thread
src/backend/opencl/types.cpp
Outdated
umar456
force-pushed
the
tidy
branch
2 times, most recently
from
36ad79a to
e266769
Compare
April 14, 2020 23:12
9prady9
reviewed
Apr 15, 2020
9prady9
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
This is becoming too big, we should resolve the compilation problems and get it merged it.
Sorry, something went wrong.
9prady9
approved these changes
Apr 15, 2020
umar456
added a commit
to umar456/arrayfire
that referenced
this pull request
Jun 27, 2020
* Add clang-tidy configuration file * Cleanup some exception code * Add additional upstream directories to .gitignore * Remove unused parameters from wrap and transform implementations * Fix warnings and removed unused calls
9prady9
pushed a commit
that referenced
this pull request
Jun 27, 2020
* Add clang-tidy configuration file * Cleanup some exception code * Add additional upstream directories to .gitignore * Remove unused parameters from wrap and transform implementations * Fix warnings and removed unused calls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a clang-tidy config file and applies the changes to the code. There are many changes that still need to be made but the current state is working and all backends are built with these settings. Many settings were disabled because they produced warnings that were invalid in our code base or would require changes to headers we don't control. Several bugs have been found in the course of this change. I tried to include only changes that did not change the functionality of the code. Bug fixes have been or will be submitted in other PRs.
You can run clang-tidy by passing -DCMAKE_CXX_CLANG_TIDY="clang-tidy". If you want to apply fixes you can pass -DCMAKE_CXX_CLANG_TIDY="clang-tidy;--fix" although this will make some changes in the code below which I want to investigate further.