Repository navigation
Enable support for large kernels in morphological ops - #2852
Merged
umar456 merged 5 commits intoApr 22, 2020
Merged
umar456 merged 5 commits into
umar456 merged 5 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
9prady9
force-pushed
the
issue1941_morphological_ops
branch
2 times, most recently
from
4cfb4f5 to
6c7a51d
Compare
April 21, 2020 12:30
Copy link
Copy Markdown
Member
Author
|
I am looking into the regression failures on windows/ubuntu(MKL) CPU jobs. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Was able to reproduce, seems to be happening with MKL based fft only. Looking into it. |
Sorry, something went wrong.
9prady9
force-pushed
the
issue1941_morphological_ops
branch
2 times, most recently
from
d515c05 to
479bab0
Compare
April 22, 2020 09:36
This removes redundant flip implementation at src/api/c/ level again.
b8(binary images) don't have any size limitations for structuring-element/kernel starting with this change. For such larger kernels, convolution(fft) based implementation is used.
9prady9
force-pushed
the
issue1941_morphological_ops
branch
from
479bab0 to
c1d7088
Compare
April 22, 2020 19:13
umar456
approved these changes
Apr 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1941
Requires arrayfire/arrayfire-data#18