Repository navigation
Refactor padArray to reshape; Refactor qr,solve to use padArrayBorders - #2864
Merged
9prady9 merged 4 commits intoApr 29, 2020
Merged
9prady9 merged 4 commits into
9prady9 merged 4 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
9prady9
marked this pull request as ready for review
April 29, 2020 13:40
umar456
reviewed
Apr 29, 2020
Comment thread
src/api/c/fft_common.hpp
Outdated
Comment thread
src/backend/cpu/resize_array.cpp
Outdated
Comment thread
src/backend/opencl/resize_array.cpp
Outdated
Comment thread
src/backend/opencl/solve.cpp
Outdated
Moved reshape implementations into separate source files to speedup compilation further.
umar456
approved these changes
Apr 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes a couple of other fixes too.