Repository navigation
adds bitwise not(~) operation to all backends - #2865
Merged
9prady9 merged 1 commit intoMay 2, 2020
Merged
9prady9 merged 1 commit into
9prady9 merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
umar456
reviewed
Apr 29, 2020
Comment thread
include/af/arith.h
9prady9
requested changes
Apr 30, 2020
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
We have missing af_bitnot in unified API. A lot of math tests failed on Window job.
Sorry, something went wrong.
Comment thread
include/af/arith.h
Comment thread
src/api/c/unary.cpp
Comment thread
src/api/c/unary.cpp
Outdated
Comment thread
src/api/cpp/array.cpp
Outdated
Comment thread
test/binary.cpp
Outdated
Comment thread
test/binary.cpp
Outdated
9prady9
approved these changes
May 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This unary operation had been missing. Twos complement -x - 1 trick would fail for some types due to our upcasting behavior.