FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix error with GCC 6.1. Fixed warnings and Serialize test by umar456 · Pull Request #2876 · arrayfire/arrayfire · GitHub

  1. arrayfire
  2. arrayfire

Repository navigation

Fix error with GCC 6.1. Fixed warnings and Serialize test - #2876

Merged
9prady9 merged 2 commits into
arrayfire:masterfrom
umar456:gcc61_error
May 6, 2020
ConversationCommits (2)ChecksFiles changed
Merged

Fix error with GCC 6.1. Fixed warnings and Serialize test#2876
9prady9 merged 2 commits into
arrayfire:masterfrom
umar456:gcc61_error

Conversation

umar456 commented May 6, 2020 •
edited
Loading

Copy link
Copy Markdown
Member
  • the default implementation of the AfError move constructor was not marked noexcept but our definition included the noexcept specification. This caused an error in GCC 6.1. I worked around this by defining the Move constructor.
  • Made a couple of tests serial which used mulitple cores
  • Fixed an overflow warning.

Fixes #2874

umar456 added the build label May 6, 2020
umar456 added this to the 3.7.2 milestone May 6, 2020
9prady9 merged commit 9d4cec2 into arrayfire:master May 6, 2020
umar456 deleted the gcc61_error branch June 26, 2020 18:37
umar456 mentioned this pull request Jun 27, 2020
Merged
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

9prady9 9prady9 approved these changes

Assignees

No one assigned

Labels

build

Projects

None yet

Milestone

3.7.2

Development

Successfully merging this pull request may close these issues.

Compilation failure with gcc 6

2 participants

Back | FazBrowse Home | New Git URL