Repository navigation
Support building ArrayFire with the device symbols flag - #2957
Merged
umar456 merged 7 commits intoJul 2, 2020
Merged
umar456 merged 7 commits into
umar456 merged 7 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
* ArrayFire couldn't be compiled using device debug symbols because the get_stream and synchronize_stream functions with the ThrustArrayFirePolicy needed to be device and host compatible. These functions were using some host only functions so they couldn't be compiled for the device. Although these functions aren't really used, they caused missing symbol errors when passing the -G flag.
umar456
force-pushed
the
fix_thrust_policy
branch
from
953e933 to
e2caeb6
Compare
July 1, 2020 22:28
syurkevi
previously approved these changes
Jul 1, 2020
Copy link
Copy Markdown
Member
|
fyi: opencl reduce failed. |
Sorry, something went wrong.
the gidx was incorrectly being used as gid
umar456
force-pushed
the
fix_thrust_policy
branch
from
b692a5d to
3a49ea9
Compare
July 2, 2020 18:58
umar456
force-pushed
the
fix_thrust_policy
branch
from
3a49ea9 to
fe42e70
Compare
July 2, 2020 19:07
9prady9
approved these changes
Jul 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ArrayFire was failing to build with NVCC's -G(device symbols) flag.
Description
Support compiling of ArrayFire with the -G flag in NVCC. This flag embeds device symbols in the binary
so that you could debug CUDA kernels using cuda-gdb. Compiling with device debug symbols was failing
because we were calling host functions from functions that supported both device and host code.
This PR also addresses an issue where we were using the default stream when calling CUB functions
in reduce by key.
Tests for reduce by keys don't pass in the current master with debug symbols because of the newer
version of CUB used. The older version of CUB passes the tests but it is not compatible with CUDA 11.
This is still being investigated and I have NOT included the fix as part of this PR.
Changes to Users
N/A
Checklist