Repository navigation
Fix cmake arguments for external projects for msvc - #3088
Merged
9prady9 merged 2 commits intoFeb 12, 2021
Merged
9prady9 merged 2 commits into
9prady9 merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Without the additional toolset argument being forwarded to msvc toolchain, cmake/msvc is free to choose a toolset as per their respective logic. This causes build issues. Also fixed some conditions that are based on CMakeBuildType variable - not recommended to use checks based on that variable and often resulted in issues when used with untested multi-config generators.
umar456
reviewed
Feb 11, 2021
Comment thread
CMakeLists.txt
Outdated
umar456
approved these changes
Feb 11, 2021
9prady9
added a commit
to 9prady9/arrayfire
that referenced
this pull request
Aug 2, 2021
* Fix cmake arguments for external projects for msvc Without the additional toolset argument being forwarded to msvc toolchain, cmake/msvc is free to choose a toolset as per their respective logic. This causes build issues. Also fixed some conditions that are based on CMakeBuildType variable - not recommended to use checks based on that variable and often resulted in issues when used with untested multi-config generators. (cherry picked from commit 422f1bd)
syurkevi
pushed a commit
that referenced
this pull request
Dec 28, 2021
* Fix cmake arguments for external projects for msvc Without the additional toolset argument being forwarded to msvc toolchain, cmake/msvc is free to choose a toolset as per their respective logic. This causes build issues. Also fixed some conditions that are based on CMakeBuildType variable - not recommended to use checks based on that variable and often resulted in issues when used with untested multi-config generators. (cherry picked from commit 422f1bd)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without the additional toolset argument being forwarded to msvc
toolchain, cmake/msvc is free to choose a toolset as per their
respective logic. This causes build issues.
Also fixed some conditions that are based on CMakeBuildType variable -
not recommended to use checks based on that variable and often resulted
in issues when used with untested multi-config generators.
Changes to Users
None unless it is an user building ArrayFire on Windows platform.
Checklist