Repository navigation
Build option AF_COMPUTE_LIBRARY to select CPU backend dependencies - #3138
Merged
9prady9 merged 2 commits intoJun 23, 2021
Merged
9prady9 merged 2 commits into
9prady9 merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
I don't expect most of builds to pass since MKL cmake options changed. Addressed this now |
Sorry, something went wrong.
9prady9
force-pushed
the
cleanup_linalg_deps_selection
branch
7 times, most recently
from
0d7965f to
0c59d06
Compare
May 24, 2021 09:08
Copy link
Copy Markdown
Member
Author
|
I will investigate the following new failures (m6000) from this PR. Interesting though, why cuda stuff failed when change has nothing to do with that backend. The following tests FAILED: 48 - test_homography_cuda (Failed) 80 - test_orb_cuda (Failed) 101 - test_gloh_cuda (Failed) 102 - test_sift_cuda (Failed) |
Sorry, something went wrong.
9prady9
force-pushed
the
cleanup_linalg_deps_selection
branch
from
1b9fd32 to
126e878
Compare
June 21, 2021 09:45
This new cmake option can take the following values - `Intel-MKL` - Intel MKL is used for blas, fft and sparse related routines - `FFTW/LAPACK/BLAS` - OpenBLAS for blas routines; fftw for fft routines; netlib compatible lapack library for lapack routines - `Intel-MKL` is the default value of this option. We intend to add AMD-AOCL as the third option. To preserve the behavior provided by the old flags, USE_CPU_MKL & USE_OPENCL_MKL, if provided(command-line/cmake-gui) will take precedence even if `AF_COMPUTE_LIBRARY` has `FFTW/LAPACK/BLAS`. Add back vcpkg caching mechanism. The work around we tried so far has increased the build time too much on windows github action Putting vcpkg under arrayfire source root or build folder is making vcpkg think it is in manifest mode and any `vcpkg install` commands are not doing expected standalone dependency installations. Cannot use af_deprecate calls of USE_*_MKL flags, it cannot handle different type cmake variables
9prady9
force-pushed
the
cleanup_linalg_deps_selection
branch
from
126e878 to
fde0efb
Compare
June 22, 2021 14:38
umar456
approved these changes
Jun 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Build option AF_COMPUTE_LIBRARY to select CPU compute dependency
This new cmake option can take the following values
We intend to add AMD-AOCL as the third option.
To preserve the behavior provided by the old flags, USE_CPU_MKL & USE_OPENCL_MKL, if provided(command-line/cmake-gui) will take precedence even if AF_COMPUTE_LIBRARY has FFTW/LAPACK/BLAS.
Changes to Users
None
Checklist