Repository navigation
Free unlocked buffers before tests run in rng quality tests - #3151
9prady9 merged 2 commits into
Conversation
Sorry, something went wrong.
This is needed when running rng quality tests on lesser memory cards where higher memory usage is causing out of memory issues.
| virtual void SetUp() { | ||
| //Ensure all unlocked buffers are freed | ||
| // Ensure all unlocked buffers are freed | ||
| deviceGC(); |
There was a problem hiding this comment.
If you want to unlock all buffers, you need to add af::sync() before the deviceGC().
Without the sync, the buffers which are still in use by executing kernels will not be freed.
Sorry, something went wrong.
There was a problem hiding this comment.
That is not the case with deviceGC in this location. When test finishes, all arrays involved are already evaluated because they need to be brought to host for comparison. So, they will be marked as unused by the time this line hits before the next test starts.
Sorry, something went wrong.
There was a problem hiding this comment.
Additionally all allocation and free function are device synchronization events.
Sorry, something went wrong.
* Free unlocked buffers before tests run in rng quality tests This is needed when running rng quality tests on lesser memory cards where higher memory usage is causing out of memory issues. * Fix formatting (cherry picked from commit bde5bd2)
Description
This is needed when running rng quality tests on lesser memory cards
where higher memory usage is causing out of memory issues.
Changes to Users
None
Checklist