Repository navigation
Fix canny_opencl tests for Intel CPUs - #3164
Merged
9prady9 merged 2 commits intoJul 30, 2021
Merged
9prady9 merged 2 commits into
9prady9 merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
The barrier in the while loop is necessary for Intel CPUs and maybe other platforms to work correctly. I am not sure why it is required because we seem to be performing sufficient synchronization otherwise.
9prady9
approved these changes
Jul 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an error in the CannyEdgeDetector.OtsuThreshold test which appeared on the Intel CPU OpenCL implementation.
Description
Fixes an infinite loop error that occurred on Intel OpenCL platform targeting the CPU. The fix is to add a barrier at the end of the while loop in the edgeTrackKernel. I am not sure why this is necessary because there is sufficient synchronization there but this barrier fixes the issue.
Changes to Users
N/A
Checklist