Repository navigation
Canny empty array fix - #3169
Merged
umar456 merged 3 commits intoAug 17, 2021
Merged
umar456 merged 3 commits into
umar456 merged 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
umar456
force-pushed
the
canny_empty_arry_fix
branch
3 times, most recently
from
804535b to
1cbaf19
Compare
August 16, 2021 16:58
The otsuThreshold function was creating an empty Array for the sigmas variable and this sometimes failed because the last value was not always written to. This commit adjusts the size of the sigmas array to better match the values that are assigned to it
Prior to this change, edge tracking CPU backend kernel wasn't processing the batch input sets. Thus, the output of corresponding input sets was missing in the array returned by canny API. This is fixed now. Added a batch test for this scenario.
9prady9
force-pushed
the
canny_empty_arry_fix
branch
from
1cbaf19 to
9acb6e1
Compare
August 17, 2021 13:56
Co-authored-by: Umar Arshad <umar@arrayfire.com>
9prady9
force-pushed
the
canny_empty_arry_fix
branch
from
9acb6e1 to
75bc1d5
Compare
August 17, 2021 14:58
9prady9
approved these changes
Aug 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The otsuThreshold function was creating an empty Array for the sigmas variable
and this sometimes failed because the last value was not always written to. This
PR adjusts the size of the array so that the extra element is not used.
Description
The otsuThreshold function was creating an empty Array for the sigmas variable
and this sometimes failed because the last value was not always written to. This
PR adjusts the size of the array so that the extra element is not used.
This PR also removes a couple of reductions in the otsuThreshold function. These
reductions are replaced by a scan.
Changes to Users
Checklist