FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Use appropriate MKL getrs_batch_strided API based on MKL Versions by 9prady9 · Pull Request #3181 · arrayfire/arrayfire · GitHub

Repository navigation

Use appropriate MKL getrs_batch_strided API based on MKL Versions - #3181

Merged
9prady9 merged 2 commits into
arrayfire:masterfrom
9prady9:fix_solve_batch_upstream_signature
Oct 14, 2021
Merged

9prady9 merged 2 commits into
arrayfire:masterfrom
9prady9:fix_solve_batch_upstream_signature

Conversation

9prady9 commented Oct 13, 2021

Copy link
Copy Markdown
Member

Description

Fixes #3180 compilation issue on some distros/gcc combination for CPU and OpenCL backend.

Changes to Users

None

Checklist

  • Rebased on latest master
  • Code compiles
  • Tests pass
  • [ ] Functions added to unified API
  • [ ] Functions documented

9prady9 added this to the 3.8.1 milestone Oct 13, 2021
9prady9 force-pushed the fix_solve_batch_upstream_signature branch from 97611cf to 694b77e Compare October 13, 2021 10:44
9prady9 changed the title Add missing const qualifier for MKL API signatures Use appropriate MKL getrs_batch_strided API based on MKL Versions Oct 13, 2021
9prady9 force-pushed the fix_solve_batch_upstream_signature branch from 694b77e to 81e9a55 Compare October 13, 2021 10:47
9prady9 force-pushed the fix_solve_batch_upstream_signature branch from 917f188 to a3992f9 Compare October 13, 2021 12:55
9prady9 merged commit 1ff07ca into arrayfire:master Oct 14, 2021
9prady9 deleted the fix_solve_batch_upstream_signature branch October 14, 2021 05:43

Copy link
Copy Markdown

Hi,

I am trying to use Arrayfire(v3.8.1) in my project.

I am using MKL version 20220000 and I have exactly the same issue described in #3180.

Does this commit really fix the building issue?

The compile works fine if I comments out the version contional at the header inclusion part.

#if INTEL_MKL_VERSION >= 20210004. (here)
#include <mkl_version.h>
#endif (and here)

The header mkl_version.h is the file that defines the macro INTEL_MKL_VERSION. Since the macro is used before the header inclusion, when the conditional is evaluated, INTEL_MKL_VERSION will be 0 (undefined). So, the header will never be included. This means the successing conditionals will be all false, the not-const type for the pointer is still used, and the compile error occurs.

So I think the version checking conditional for the header inclusion should be deleted.

Thank you.

Useong Kim

9prady9 commented Feb 18, 2022

Copy link
Copy Markdown
Member Author

Unfortunately, this fix is broken. There has been another fix recently which actually takes care of this. It will be available in next release.

Copy link
Copy Markdown

Thanks.

I can see the solution in the master branch.

Copy link
Copy Markdown
Contributor

@9prady9 @umar456 The 3.8 branch does nt seem to be compat with recent MKL (2021.4 and later) because of these changes of API. Any way to cherry pick that fix into the 3.8 branch ?

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Build] Build with Intel MKL fails with "invalid conversion" in solve.cpp

4 participants


Back | FazBrowse Home | New Git URL