Repository navigation
Add f16 support for modulus and norm - #3258
Merged
christophe-murphy merged 10 commits intoMar 7, 2025
Merged
christophe-murphy merged 10 commits into
christophe-murphy merged 10 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
umar456
force-pushed
the
half_mod
branch
4 times, most recently
from
6e0dec7 to
9c1389e
Compare
June 10, 2022 22:40
float math functions in CUDA have the format f<op>f
syurkevi
self-requested a review
September 12, 2022 19:20
syurkevi
previously requested changes
Sep 12, 2022
… cpu backend according to other backends
edwinsolisf
reviewed
Feb 5, 2025
Comment thread
src/backend/cpu/binary.hpp
Copy link
Copy Markdown
Contributor
|
For bookkeeping and future reference: For integers, af_rem_t/af::rem and af_mod_t/af::mod should produce the output as just using the % operator on integers. For floats, af_rem_t/af::rem should reproduce the output of remainder/std::remainder from the C/C++ math headers, and af_mod_t/af::mod should reproduce the output of fmod/std::fmod. |
Sorry, something went wrong.
christophe-murphy
approved these changes
Mar 7, 2025
christophe-murphy
dismissed
syurkevi’s stale review
March 7, 2025 17:08
Comments have been addressed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for f16 for modulus and norm. This PR also adds tests for the norm function
Description
Fixes: #3256
Changes to Users
Checklist