FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Compiler flag adjustments for Intel Compiler by umar456 · Pull Request #3334 · arrayfire/arrayfire · GitHub

  1. arrayfire
  2. arrayfire

Repository navigation

Compiler flag adjustments for Intel Compiler - #3334

Merged
umar456 merged 4 commits into
arrayfire:masterfrom
umar456:github_actions_compiler
Nov 22, 2022
ConversationCommits (4)ChecksFiles changed
Merged

Compiler flag adjustments for Intel Compiler#3334
umar456 merged 4 commits into
arrayfire:masterfrom
umar456:github_actions_compiler

Conversation

umar456 commented Nov 22, 2022

Copy link
Copy Markdown
Member

The Intel compiler uses fast math by default in order to perform some optimization. These
optimizations causes some of our tests to fail. This PR handles several of the issues
brought up with the new compiler

Description

  • Add AF_WITH_FAST_MATH to options which enable the use of fast math flags in all compilers. This is off by default
  • Fix several warnings with clang and icx
  • Refactor GitHub actions so that the builds only execute if clang-format and docs pass
  • Add additional compilers to GitHub actions

Changes to Users

  • Users can now enable AF_WITH_FAST_MATH for additional performance at the cost of precision

Checklist

  • Rebased on latest master
  • Code compiles
  • Tests pass
  • [ ] Functions added to unified API
  • [ ] Functions documented

9prady9 reviewed Nov 22, 2022
View reviewed changes

9prady9 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

did a quick pass, lgtm

Comment thread src/backend/common/TemplateArg.hpp
Comment thread test/testHelpers.hpp Outdated
umar456 force-pushed the github_actions_compiler branch from 2f3b914 to 384e52b Compare November 22, 2022 07:28

umar456 commented Nov 22, 2022

Copy link
Copy Markdown
Member Author

Addressed all feedback.

umar456 force-pushed the github_actions_compiler branch from 384e52b to d17c212 Compare November 22, 2022 07:30
umar456 merged commit 65e6740 into arrayfire:master Nov 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

9prady9 9prady9 left review comments
syurkevi syurkevi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL