Repository navigation
Update OpenCL to 3.0. Add checks around tests that use doubles. - #3338
Merged
umar456 merged 17 commits intoJan 21, 2023
Merged
umar456 merged 17 commits into
umar456 merged 17 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
umar456
force-pushed
the
double_checks_opencl
branch
7 times, most recently
from
7234cb2 to
397459e
Compare
December 2, 2022 23:53
syurkevi
reviewed
Dec 6, 2022
Comment thread
src/backend/cuda/compile_module.cpp
Outdated
syurkevi
reviewed
Dec 6, 2022
Comment thread
CMakeModules/vcpkg/ports/opencl/vcpkg-cmake-wrapper.cmake
Outdated
syurkevi
reviewed
Dec 6, 2022
Comment thread
src/backend/opencl/platform.hpp
Outdated
umar456
force-pushed
the
double_checks_opencl
branch
2 times, most recently
from
91824df to
659bc8b
Compare
January 11, 2023 21:16
umar456
force-pushed
the
double_checks_opencl
branch
6 times, most recently
from
72d1247 to
0cda5a4
Compare
January 20, 2023 19:40
umar456
force-pushed
the
double_checks_opencl
branch
2 times, most recently
from
ae41af0 to
0f54a02
Compare
January 20, 2023 22:15
umar456
force-pushed
the
double_checks_opencl
branch
from
0f54a02 to
1d36f1f
Compare
January 21, 2023 00:33
syurkevi
approved these changes
Jan 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the OpenCL standard to 3.0 from 1.2. Additionally this PR adds some checks around tests that use double precision numbers on devices that don't support double precision. This PR also fixes the pow function when fast math is used.
Description
Changes to Users
N/A
Checklist