Repository navigation
Corrected field example (#3369) - #3375
Merged
christophe-murphy merged 2 commits intoJan 7, 2025
Merged
christophe-murphy merged 2 commits into
christophe-murphy merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
9prady9
reviewed
Mar 27, 2023
willyborn
force-pushed
the
field3369
branch
2 times, most recently
from
1771cce to
9d72403
Compare
March 28, 2023 21:31
christophe-murphy
marked this pull request as draft
August 30, 2024 00:14
christophe-murphy
marked this pull request as ready for review
August 30, 2024 00:15
christophe-murphy
self-requested a review
August 30, 2024 00:15
Copy link
Copy Markdown
Contributor
|
@9prady9 , I'll pick up this review if you have no objections |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
@willyborn I'm happy with the changes you have made to the setup_vector_field routine. The field example is working with that fix. I see that you have made other changes to the join method to check the dimensions and handle the case where the stride is not 1 in the first dimension. I think there is more work to be done on the other versions of the join routine to fully support this. There should probably also be additional tests added to the join test suite for this. I suggest that we just merge the setup_vector_field changes here and open a separate issue for the join method changes. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
OK.
I have to resync to the latest env. so this could take some time looking at
the recent build problems, some experience.
Willy
…On Fri, 30 Aug 2024 at 02:25, Christophe Murphy ***@***.***> wrote:
@willyborn <https://github.com/willyborn> I'm happy with the changes you
have made to the setup_vector_field routine. The field example is working
with that fix. I see that you have made other changes to the join method to
check the dimensions and handle the case where the stride is not 1 in the
first dimension. I think there is more work to be done on the other
versions of the join routine to fully support this. There should probably
also be additional tests added to the join test suite for this. I suggest
that we just merge the setup_vector_field changes here and open a separate
issue for the join method changes.
—
Reply to this email directly, view it on GitHub
<#3375 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQ2WGPFXSDXNY2PMZ7VBVW3ZT63ZBAVCNFSM6AAAAAAV2S2GCKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJZGUZTONBWGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sorry, something went wrong.
willyborn
force-pushed
the
field3369
branch
from
9d72403 to
bf5c11e
Compare
September 11, 2024 15:05
Comment thread
examples/graphics/field.cpp
Copy link
Copy Markdown
Contributor
Author
|
vectorField is a graphical function, so it is not included in the test
series. The only way to test it, is by using it in examples.
The are 3 versions of vectorField, dependent on the provision of the
coordinates
1. full coordinates in 1 array
2. X & Y axis as separate arrays
3. X, Y & Z axis as separate arrays
The corrected error is the part that combines all those different
provisions (join) into 1 common set that is forwarded to forge to display.
So in the example I added the 2nd form so that it can be verified.
PS: The last form 3D is not included since forge has problems displaying
those. I noticed that multiple 3D examples are broken.
Willy
…On Wed, 2 Oct 2024 at 19:20, Christophe Murphy ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In examples/graphics/field.cpp
<#3375 (comment)>:
> myWindow(0, 0).vectorField(points, saddle, "Saddle point");
myWindow(0, 1).vectorField(
points, hbowl, "hilly bowl (in a loop with varying amplitude)");
+
+ // 2D coordinates
+ myWindow(1, 0).vectorField(2.0 * flat(x), flat(y), flat(x),
What are these extra plots for?
—
Reply to this email directly, view it on GitHub
<#3375 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQ2WGPFGG6GHRQ5DOK57LOLZZQTPFAVCNFSM6AAAAAAV2S2GCKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGNBTGU4TKNJZGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sorry, something went wrong.
christophe-murphy
approved these changes
Jan 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uninitialized buffer used to collect partial join (2D -> 3D)
Join now accepts any buffer as out array, as long as it is large enough.
Description
Fixes: #3369
Changes to Users
Non
Checklist