FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

multi threaded OPENBLAS by willyborn · Pull Request #3376 · arrayfire/arrayfire · GitHub

  1. arrayfire
  2. arrayfire

Repository navigation

multi threaded OPENBLAS - #3376

Merged
umar456 merged 1 commit into
arrayfire:masterfrom
willyborn:multithreadedOPENBLAS
Mar 16, 2023
ConversationCommits (1)ChecksFiles changed
Merged

multi threaded OPENBLAS#3376
umar456 merged 1 commit into
arrayfire:masterfrom
willyborn:multithreadedOPENBLAS

Conversation

willyborn commented Mar 14, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Adds the threads options to OPENBLAS & FFT VCPKG compilation.

Description

  • Improvement, by specializing options during VCPKG compilation

Changes to Users

Improved speed when using OPENBLAS.

Checklist

  • Rebased on latest master
  • Code compiles
  • Tests pass
  • [-] Functions added to unified API
  • [-] Functions documented

umar456 reviewed Mar 14, 2023
View reviewed changes
Comment thread vcpkg.json Outdated
"description": "Build OpenCL backend",
"dependencies": [
"boost-compute",
"boost-program-options",

umar456 Mar 14, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I don't think this is a good dependency for the project. It is only required for some of the tests in the clFFT project and those aren't built. I think the vcpkg should minimize the number of dependencies installed whenever possible.

willyborn Mar 14, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

OK.
I get it out, and resend the PR.

willyborn Mar 14, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Or should I move it to the openblasfftw section ?

umar456 Mar 14, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

You should remove it. We don't need that dependency to build ArrayFire.

willyborn Mar 14, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

OK, done

willyborn force-pushed the multithreadedOPENBLAS branch from 90dd9d7 to 7f242c8 Compare March 14, 2023 18:27
umar456 merged commit 1e4b1a0 into arrayfire:master Mar 16, 2023
willyborn deleted the multithreadedOPENBLAS branch May 11, 2023 21:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

umar456 umar456 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL