Repository navigation
Fixed padding comparison in convolve2GradientNN - #3519
Merged
christophe-murphy merged 1 commit intoJan 13, 2025
Merged
christophe-murphy merged 1 commit into
christophe-murphy merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
syurkevi
approved these changes
Oct 31, 2023
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A padding issue that was fixed for convolve2NN back in 2020 (PR #2820) was not corrected in the corresponding convolve2GradientNN function.
This is a simple fix of the comparison, to allow for 0 padding.
This PR does not change any of the interfaces.
Checklist