Repository navigation
Fix build failure of cuda backend when cudnn is used. - #3521
Merged
christophe-murphy merged 5 commits intoAug 30, 2024
Merged
christophe-murphy merged 5 commits into
christophe-murphy merged 5 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
FloopCZ
approved these changes
Mar 7, 2024
Copy link
Copy Markdown
Contributor
|
The PR fixes #3506 for me and the code seems reasonable. |
Sorry, something went wrong.
Reformat cudnn status fix
christophe-murphy
previously approved these changes
Aug 30, 2024
christophe-murphy
approved these changes
Aug 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Casts the cudnnStatus_t enumeration to the underlying integer type prior to passing to fmt::format.
Additionally fixes an incorrect call to dependency_check in the test configuration when AF_WITH_EXTERNAL_PACKAGES_ONLY is set.
Description
Fixes: #3506.
Includes type_traits in the src/backend/cuda/platform.cpp file.
Uses only c++11 features.
Changes to Users
No changes to downstream users.
Checklist