Fix for 1693 bug access to deleted memory in array proxy index - #3600
Open
christophe-murphy wants to merge 10 commits into
Open
Fix for 1693 bug access to deleted memory in array proxy index#3600christophe-murphy wants to merge 10 commits into
christophe-murphy wants to merge 10 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…nce index to ensure it is kept.
umar456
reviewed
Feb 4, 2025
Comment thread
src/api/cpp/array.cpp
Outdated
Copy link
Copy Markdown
Contributor
Author
|
OK, I reran address sanitizer on the CUDA backend with the following options and it ran without any issues reported: protect_shadow_gap=0:replace_intrin=0:detect_stack_use_after_return=0 |
Sorry, something went wrong.
… for memory leaks.
Copy link
Copy Markdown
Contributor
Author
|
I have done some more testing, see latest commit. I ran these through the leak sanitizer for all back ends and, aside from an unrelated memory leak in the random number generator engine, there are no issues. |
Sorry, something went wrong.
The copy constructors for array_proxy have been made private. This will prevent you from assigning an array proxy to an auto variable accidently. Array proxies should only be assigned to variables of type array. Assigning to an auto will now lead to a compilation error.
edwinsolisf
previously approved these changes
Mar 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
At least 1 approving review is required to merge this pull request.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Arrays can now be used as an index for creating an array proxy without failure.
Description
When using an array as an index when creating an array proxy a temporary index object is created and passed to the constructor for the array proxy. However the array underlying the index was not being kept after the temporary index was destroyed, resulting in undefined behavior. This fix ensures that the array is retained until the array proxy is destroyed. Users can now use an array as an index when creating an array proxy without needing to explicitly define an index object.
Fixes: #1693
Checklist