Repository navigation
1918 sparse matrix not updated in for loop in opencl - #3602
Merged
christophe-murphy merged 3 commits intoJan 8, 2025
Merged
christophe-murphy merged 3 commits into
christophe-murphy merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…s and/or row/cols arrays are not accounted for when converting a sparse array to a dense one. This can happen when a sparse matrix is constructed using values and/or row/cols arrays that have been indexed using the seq method.
edwinsolisf
self-requested a review
December 30, 2024 20:29
edwinsolisf
approved these changes
Dec 30, 2024
edwinsolisf
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Tested changes on windows with OpenCL
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for issue in the opencl backend where array offsets for the values and/or row/cols arrays are not accounted for when converting a sparse array to a dense one.
Description
A sparse csr matrix may be constructed using arrays for the values and the row and column indices. When these arrays are indexed using the seq method, the offsets into them are stored. These offsets were not being accounted for in the sparse to dense conversion function which can result in incorrect values in the resulting dense matrix. This PR fixes that.
Fixes: #1918
Checklist